Skip to content

Commit da23dff

Browse files
authored
[video_player] Remove package in example AndroidManifest.xml file (#10245)
discovered while investigating [#176575](flutter/flutter#176575) opening the `example/android` folder in android studio , this warning appears `along others` : ```logs > Task :app:processDebugMainManifest package="io.flutter.plugins.videoplayerexample" found in source AndroidManifest.xml: video_player\video_player\example\android\app\src\main\AndroidManifest.xml. Setting the namespace via the package attribute in the source AndroidManifest.xml is no longer supported, and the value is ignored. Recommendation: remove package="io.flutter.plugins.videoplayerexample" from the source AndroidManifest.xml: video_player\video_player\example\android\app\src\main\AndroidManifest.xml. ``` ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 3ff8455 commit da23dff

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

packages/video_player/video_player/example/android/app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
2-
package="io.flutter.plugins.videoplayerexample">
1+
<manifest xmlns:android="http://schemas.android.com/apk/res/android">
32

43
<application
54
android:icon="@mipmap/ic_launcher"

0 commit comments

Comments
 (0)