Commit f56d5a9
authored
Fix
This target was using `release_build: true` as a way to skip release
branches. This flag is used to signal engine artifacts are built - they
need to be skipped:
- in release branches because artifacts are produced through other
paths.
- in postsubmits of monorepo since the engine artifacts are produced in
the merge queue.
This target was the only one in the framework defining it this way. It
should have been using `enabled_branches`.
tested: locally, using CiYaml directly with a copy of flutter's ci.yaml:
```dart
final YamlMap configYaml = loadYaml(await File(args.command!['file']).readAsString()) as YamlMap;
final pb.SchedulerConfig schedulerConfig = pb.SchedulerConfig()..mergeFromProto3Json(configYaml);
final masterYaml = CiYamlSet(
yamls: {
CiType.any: schedulerConfig,
},
slug: RepositorySlug.full('flutter/flutter'),
branch: 'master',
validate: false,
isFusion: false,
);
final masterNames = {...masterYaml.postsubmitTargets().map((t) => t.value.name)};
final releaseYaml = CiYamlSet(
yamls: {
CiType.any: schedulerConfig,
},
slug: RepositorySlug.full('flutter/flutter'),
branch: 'flutter-3.27-candidate.0',
validate: false,
isFusion: false,
);
final releaseNames = {...releaseYaml.postsubmitTargets().map((t) => t.value.name)};
print("********************************");
print(releaseNames.contains('Linux docs_publish')); // false
print(masterNames.contains('Linux docs_publish')); // true - generate docs in postsubmit
print("********************************");
```
Fixes #162552Linux docs_publish running at head (#162557)1 parent 039d0db commit f56d5a9
1 file changed
+6
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
577 | 577 | | |
578 | 578 | | |
579 | 579 | | |
| 580 | + | |
| 581 | + | |
| 582 | + | |
| 583 | + | |
| 584 | + | |
| 585 | + | |
580 | 586 | | |
581 | 587 | | |
582 | 588 | | |
| |||
591 | 597 | | |
592 | 598 | | |
593 | 599 | | |
594 | | - | |
595 | 600 | | |
596 | 601 | | |
597 | 602 | | |
| |||
0 commit comments