Skip to content

Commit f56d5a9

Browse files
authored
Fix Linux docs_publish running at head (#162557)
This target was using `release_build: true` as a way to skip release branches. This flag is used to signal engine artifacts are built - they need to be skipped: - in release branches because artifacts are produced through other paths. - in postsubmits of monorepo since the engine artifacts are produced in the merge queue. This target was the only one in the framework defining it this way. It should have been using `enabled_branches`. tested: locally, using CiYaml directly with a copy of flutter's ci.yaml: ```dart final YamlMap configYaml = loadYaml(await File(args.command!['file']).readAsString()) as YamlMap; final pb.SchedulerConfig schedulerConfig = pb.SchedulerConfig()..mergeFromProto3Json(configYaml); final masterYaml = CiYamlSet( yamls: { CiType.any: schedulerConfig, }, slug: RepositorySlug.full('flutter/flutter'), branch: 'master', validate: false, isFusion: false, ); final masterNames = {...masterYaml.postsubmitTargets().map((t) => t.value.name)}; final releaseYaml = CiYamlSet( yamls: { CiType.any: schedulerConfig, }, slug: RepositorySlug.full('flutter/flutter'), branch: 'flutter-3.27-candidate.0', validate: false, isFusion: false, ); final releaseNames = {...releaseYaml.postsubmitTargets().map((t) => t.value.name)}; print("********************************"); print(releaseNames.contains('Linux docs_publish')); // false print(masterNames.contains('Linux docs_publish')); // true - generate docs in postsubmit print("********************************"); ``` Fixes #162552
1 parent 039d0db commit f56d5a9

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.ci.yaml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,6 +577,12 @@ targets:
577577
timeout: 60
578578
dimensions:
579579
os: "Linux"
580+
enabled_branches:
581+
# Produces docs for main-api.flutter.dev
582+
# stable and beta are managed by the targets:
583+
# - Linux docs_deploy_beta
584+
# - Linux docs_deploy_stable
585+
- master
580586
properties:
581587
cores: "32"
582588
dependencies: >-
@@ -591,7 +597,6 @@ targets:
591597
validation_name: Docs
592598
firebase_project: main-docs-flutter-prod
593599
release_ref: refs/heads/master
594-
release_build: "true"
595600
drone_dimensions:
596601
- os=Linux
597602

0 commit comments

Comments
 (0)