Don't force GooglePlayPurchaseParam

Author: mvanbeusekom

packages/in_app_purchase/in_app_purchase_android/lib/src/in_app_purchase_android_platform.dart

@@ -130,22 +130,20 @@ class InAppPurchaseAndroidPlatform extends InAppPurchasePlatform {
 
   @override
   Future<bool> buyNonConsumable({required PurchaseParam purchaseParam}) async {
-    if (!(purchaseParam is GooglePlayPurchaseParam)) {
-      throw ArgumentError(
-        'On Android, the `purchaseParam` should always be of type `GooglePlayPurchaseParam`.',
-      );
+    ChangeSubscriptionParam? changeSubscriptionParam;
+
+    if (purchaseParam is GooglePlayPurchaseParam) {
+      changeSubscriptionParam = purchaseParam.changeSubscriptionParam;
     }
 
     BillingResultWrapper billingResultWrapper =
         await billingClient.launchBillingFlow(
             sku: purchaseParam.productDetails.id,
             accountId: purchaseParam.applicationUserName,
-            oldSku: purchaseParam
-                .changeSubscriptionParam?.oldPurchaseDetails.productID,
-            purchaseToken: purchaseParam.changeSubscriptionParam
+            oldSku: changeSubscriptionParam?.oldPurchaseDetails.productID,
+            purchaseToken: changeSubscriptionParam
                 ?.oldPurchaseDetails.verificationData.serverVerificationData,
-            prorationMode:
-                purchaseParam.changeSubscriptionParam?.prorationMode);
+            prorationMode: changeSubscriptionParam?.prorationMode);
     return billingResultWrapper.responseCode == BillingResponse.ok;
   }
 

packages/in_app_purchase/in_app_purchase_android/test/in_app_purchase_android_platform_test.dart

@@ -221,7 +221,7 @@ void main() {
 
       late StreamSubscription subscription;
       subscription = stream.listen((purchaseDetailsList) {
-        if (purchaseDetailsList.first.status == PurchaseStatus.purchased) {
+        if (purchaseDetailsList.first.status == PurchaseStatus.restored) {
           completer.complete(purchaseDetailsList);
           subscription.cancel();
         }
@@ -260,7 +260,7 @@ void main() {
         expect(purchase.verificationData.source, kIAPSource);
         expect(purchase.transactionDate, dummyPurchase.purchaseTime.toString());
         expect(purchase.billingClientPurchase, dummyPurchase);
-        expect(purchase.status, PurchaseStatus.purchased);
+        expect(purchase.status, PurchaseStatus.restored);
       });
     });
   });
@@ -271,23 +271,6 @@ void main() {
     const String consumeMethodName =
         'BillingClient#consumeAsync(String, ConsumeResponseListener)';
 
-    test('buy non consumable, throw argument exception', () {
-      final PurchaseParam purchaseParam = PurchaseParam(
-          productDetails:
-              GooglePlayProductDetails.fromSkuDetails(dummySkuDetails),
-          applicationUserName: "hashedAccountId");
-      expect(
-        () => iapAndroidPlatform.buyNonConsumable(purchaseParam: purchaseParam),
-        throwsA(
-          isA<ArgumentError>().having(
-            (e) => e.message,
-            'message',
-            'On Android, the `purchaseParam` should always be of type `GooglePlayPurchaseParam`.',
-          ),
-        ),
-      );
-    });
-
     test('buy non consumable, serializes and deserializes data', () async {
       final SkuDetailsWrapper skuDetails = dummySkuDetails;
       final String accountId = "hashedAccountId";