Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request]: share_plus android remove url_launcher #1070

Closed
ghost opened this issue Sep 16, 2022 · 7 comments · Fixed by #1295
Closed

[Request]: share_plus android remove url_launcher #1070

ghost opened this issue Sep 16, 2022 · 7 comments · Fixed by #1295
Labels
android enhancement New feature or request Hacktoberfest Issues taking part in Hacktoberfest share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin

Comments

@ghost
Copy link

ghost commented Sep 16, 2022

Plugin

share_plus

Use case

url_launcher is not required when compiling android but it will also be loaded into the app's gradle project

Proposal

Remove url_launcher when compiling android

@ghost ghost added enhancement New feature or request triage labels Sep 16, 2022
@miquelbeltran
Copy link
Member

makes sense, feel free to submit a PR if you think you can do it!

@miquelbeltran miquelbeltran added share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin android and removed triage labels Sep 16, 2022
@mhadaily mhadaily added the Hacktoberfest Issues taking part in Hacktoberfest label Sep 28, 2022
@aakash-pamnani
Copy link
Contributor

url_launcher is in dependency of share_plus_linux and share_plus_web how can we stop it from being importing in android build, Can anybody guid me?

@SirusCodes
Copy link
Contributor

I feel it's only possible if we have federated plugins.

@miquelbeltran
Copy link
Member

I feel it's only possible if we have federated plugins.

Nope, the dependency would still be there through the other platform dependency unfortunately

@SirusCodes
Copy link
Contributor

Nope, the dependency would still be there through the other platform dependency unfortunately

Then only way is to have platform channels for each😕

@stuartmorgan
Copy link

Since url_launcher is fully federated, you could in theory depend directly on url_launcher_linux and url_launcher_web instead of url_launcher. You'd have to code against the platform interface directly instead of the app-facing API though.

@SirusCodes
Copy link
Contributor

Would make a PR for it then thanks @stuartmorgan for the idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android enhancement New feature or request Hacktoberfest Issues taking part in Hacktoberfest share_plus Feature, Enhancement, Bug Fixes for Share Plus Plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants