Make client.close(); in the RemoteAdapter's sendRequest optional

[andreystavitsky]

It can be useful if HTTP client is singleton and shared between all instances in the application. Also it is useful for HTTP2

[frank06]

Where would you close the client then? Issues can arise if you don't close the connection: https://pub.dev/documentation/http/latest/http/Client/close.html

It's important to close each client when it's done being used; failing to do so can cause the Dart process to hang.

[andreystavitsky]

dart-lang/http#422 It depends

[frank06]

When should it be closed?

[andreystavitsky]

I think, if there's custom http.Client overridden, then it should be decided in the custom http.Client. Or by default it should be closed after every request, but ability to override that behaviour should be provided without overriding whole sendRequest method.

[frank06]

Like this? a6f6267

[andreystavitsky]

exactly, thank you very much!

[frank06]

It's released on 1.5.12