Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Meta Issue #51

Open
4 of 5 tasks
vsoch opened this issue Dec 22, 2022 · 0 comments
Open
4 of 5 tasks

Testing Meta Issue #51

vsoch opened this issue Dec 22, 2022 · 0 comments

Comments

@vsoch
Copy link
Member

vsoch commented Dec 22, 2022

As we get #49 finished up I want to elaborate on needs for testing

  • add support for flux option flags #49 handles basic headless tests - e.g., we can provide a headless job, and verify successful output (if deterministic) and if not, container exit codes == 0.
    • However, this doesn't yet handle jobs that require a certain number of tasks or flags. I know --test-size=4 doesn't seem to work. I think the -ompi=openmpi@5 is technically an option so it should. Update: we figured this out, at least for the headless case.
  • We also need testing for the web UI views, and this will be harder and possibly require something like selenium. We need to be sure that entrypoint continues to function (and I don't break it) Notably the flux start -> flux mini run does not work for running the web interface. (we are using the restful API as a proxy for this - if the API is running and main page is 200 response, we are good).
  • It would be good to have a two-container (service and flux runner) test case. We have some locally but I can't put on GitHub. added with nginx-servic example.
  • For within Go we need both unit tests and e2e tests. I have a lot of examples for these, and it mostly will be about deciding when t's priority to do.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant