Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configmaps and secrets shared between multiple canary deployments get deleted when one canary using them no longer exist #1046

Closed
zeot opened this issue Nov 4, 2021 · 0 comments · Fixed by #1052

Comments

@zeot
Copy link
Contributor

zeot commented Nov 4, 2021

Describe the bug

"primary" config maps and secrets used by multiple canary deployments are when the latest updated canary no longer exists.

The ownerReferences for "primary" configmaps and secrets is set to the canary triggering the creation of it, and is overwritten when the "primary" configmap or secret already exists.

To Reproduce

  1. Create a configmap or secrets
  2. Create two deployments and canaries using the configmap or secret and wait for them to finish roll-out
  3. Delete the last canary you created

Expected behavior

When a "primary" resource of a configmap or secret already exist for a canary, the ownerReferences should be preserved and the new canary should be appended to the list. This will make sure the configmap or secret is never deleted while still in use.

Additional context

  • Flagger version: 1.15
  • Kubernetes version: 1.20.9
  • Service Mesh provider: Istio
  • Ingress provider: Istio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant