Support Prometheus Annotations on ClusterIP endpoints

[alaqelsplk]

Our prometheus instance scrapes service endpoints for metrics (https://prometheus.io/docs/prometheus/latest/configuration/configuration/#endpoints) but Flagger doesn't allow us to set these annotations on the Canary and Primary ClusterIP services.

[Nirrleybo]

Hey,
Is there any status update about when to expect flagger support service annotations ?

[stefanprodan]

@Nirrleybo is this about Prometheus annotations or annotations in general? Can't you use Prometheus annotations on pods like https://github.com/weaveworks/flagger/blob/master/kustomize/podinfo/deployment.yaml#L21

[Nirrleybo]

Prometheus annotations.

Our current prometheus instance scrapes metric from the service based on the Service resource Prometheus annotations. Adding annotation to Deployment result in duplicate metrics for existing running services.... ( or am i doing something wrong ?)

Would it be possible for Flagger to copy the the annotations from my existing service resource when creating service-primary during canary deployment ?

[stefanprodan]

Remove the annotation from the service and place it on the deployment, Flagger will copy the annotation to the primary deployment.

[Nirrleybo]

@stefanprodan ok, thank you for the quick reply

[stefanprodan]

Fixed by #538