Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify App Mesh and Istio builtin metric checks #145

Closed
stefanprodan opened this issue Apr 12, 2019 · 0 comments · Fixed by #146
Closed

Unify App Mesh and Istio builtin metric checks #145

stefanprodan opened this issue Apr 12, 2019 · 0 comments · Fixed by #146
Assignees
@stefanprodan
Labels
kind/enhancement Improvement request for an existing feature

Comments

@stefanprodan
Copy link
Member

Instead of using envoy_cluster_upstream_rq / envoy_cluster_upstream_rq_time_bucket for App Mesh and istio_requests_total / istio_request_duration_seconds_bucket for Istio, Flagger should expose request-success-rate / request-duration to unify the checks.
@stefanprodan stefanprodan self-assigned this Apr 12, 2019
@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Apr 12, 2019
@stefanprodan stefanprodan mentioned this issue Apr 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefanprodan stefanprodan

Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify App Mesh and Istio builtin metric checks fluxcd/flagger
1 participant
@stefanprodan