Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to run Flagger for a single namespace #38

Closed
stefanprodan opened this issue Jan 26, 2019 · 3 comments
Closed

Add option to run Flagger for a single namespace #38

stefanprodan opened this issue Jan 26, 2019 · 3 comments
Labels
kind/enhancement Improvement request for an existing feature

Comments

@stefanprodan
Copy link
Member

Currently Flagger uses a Cluster Role and watches for canary objects in all namespaces. It should be possible to make Flagger watch a single namespace and enforce the restriction with RBAC.
@stefanprodan stefanprodan added the kind/enhancement Improvement request for an existing feature label Jan 26, 2019
@huydinhle
Copy link
Contributor

Can I work on this? I want to get familiar with flagger code base so I can debug it easier.
Thanks

@stefanprodan
Copy link
Member Author

Sure go for it.

To limit the watch to a single namespace the flaggerInformerFactory from main should be created using the WithNamespace option.

@huydinhle
Copy link
Contributor

@stefanprodan thanks for the tips on this. About enforce restriction of RBAC, do you mean that changes to rbac manifests should be lock down to namespace as well?. This will mean changes go into artifacts and charts directory

@huydinhle huydinhle mentioned this issue Mar 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement Improvement request for an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanprodan @huydinhle