You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently have the following within our canary manifest:
# The /gate/check endpoint returns 403 until /gate/open is called
- name: "promotion gate"
type: confirm-promotion
url: http://flagger-loadtester.test/gate/check
# Close the gate after rollout to block future deployments
- name: "close gate"
type: post-rollout
url: http://flagger-loadtester.test/gate/close
This works out great for halting promotions and requiring manual approval within our pipelines!
However, rollbacks have been a bit more difficult. We wanted to have rollback follow a similar procedure without having to manually edit the manifest from /halt to an endpoint that returns a 200, as provided within the examples:
Is it possible to create a separate /rollback/check, rollback/open, and rollback/close endpoint for this purpose? The current alternative is to spin up a second loadtester deployment (e.g. flagger-loadtester-rollback).
The text was updated successfully, but these errors were encountered:
@stefanprodan if you have recommendations on how you envision this approach working, I can submit a PR to handle rollback gating. I could think of a few options, the first to continue with the approach now for GateStorage and add RollbackStorage. Second, modify the GateStorage map to handle keys specifying specific gating approaches. Exposing the endpoints is the simple part, so the underlying storage seems to be the only real question to resolve.
We currently have the following within our canary manifest:
This works out great for halting promotions and requiring manual approval within our pipelines!
However, rollbacks have been a bit more difficult. We wanted to have rollback follow a similar procedure without having to manually edit the manifest from
/halt
to an endpoint that returns a 200, as provided within the examples:Is it possible to create a separate
/rollback/check
,rollback/open
, androllback/close
endpoint for this purpose? The current alternative is to spin up a second loadtester deployment (e.g. flagger-loadtester-rollback).The text was updated successfully, but these errors were encountered: