-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a separate rollback check endpoint #443
Comments
@stefanprodan if you have recommendations on how you envision this approach working, I can submit a PR to handle rollback gating. I could think of a few options, the first to continue with the approach now for GateStorage and add RollbackStorage. Second, modify the GateStorage map to handle keys specifying specific gating approaches. Exposing the endpoints is the simple part, so the underlying storage seems to be the only real question to resolve. |
@ta924 I would add |
Thanks @stefanprodan for the feedback, I will get a PR out there. |
Fixed by #449 |
We currently have the following within our canary manifest:
This works out great for halting promotions and requiring manual approval within our pipelines!
However, rollbacks have been a bit more difficult. We wanted to have rollback follow a similar procedure without having to manually edit the manifest from
/halt
to an endpoint that returns a 200, as provided within the examples:Is it possible to create a separate
/rollback/check
,rollback/open
, androllback/close
endpoint for this purpose? The current alternative is to spin up a second loadtester deployment (e.g. flagger-loadtester-rollback).The text was updated successfully, but these errors were encountered: