Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invoke IsOnline method during canary resource initialization #554

Closed
mathetake opened this issue Apr 10, 2020 · 0 comments · Fixed by #592
Closed

invoke IsOnline method during canary resource initialization #554

mathetake opened this issue Apr 10, 2020 · 0 comments · Fixed by #592
Labels
good first issue Good for newcomers kind/enhancement Improvement request for an existing feature

Comments

@mathetake
Copy link
Collaborator

mathetake commented Apr 10, 2020 •
edited
Loading

As per discussion here, we should check the availability of all metrics servers used in canary's analysis definition.

This will also clarify the meaning of providers.Interfcace.IsOnline method for provider implementors.
@mathetake mathetake added kind/enhancement Improvement request for an existing feature good first issue Good for newcomers labels Apr 10, 2020
@mathetake mathetake mentioned this issue May 15, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers kind/enhancement Improvement request for an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check metrics server availability during canary initialization fluxcd/flagger
1 participant
@mathetake