Deployment labels and annotations are not duplicated

[DerrickMartinez]

When applying a canary manifest the deployment clone named -primary is missing the fields labels and annotation from the original one. (copied from #329). Unit tests are also failing for these off the master branch.

Configured with:

• -include-label-prefix=app.kubernetes.io

Annotations and Labels of canary deployment:

annotations:
app.kubernetes.io/name: test-api
app.kubernetes.io/part-of: test-api

labels:
app.kubernetes.io/instance: test-api
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/name: test-api
helm.sh/chart: basic-app-flagger-0.1.7

What actually got copied over to primary's deployment.

No annotations
labels:
app.kubernetes.io/name: test-api-primary

[GijsvanDulmen]

I'm seeing the same thing in a demo environment of mine using the latest. This also makes it show up non-pretty in Kiali ;-)

[DerrickMartinez]

Is this resolved or was this closed as an accident?

[stefanprodan]

@DerrickMartinez as in you can see in #762 both labels and annotations are copied to the primary deployment.