bug: adding an env var from a secretKeyRef causes Canary to never progress

[vito-laurenza-zocdoc]

PR which reproduces the issue in e2e tests: #779

Adding an env var to a Deployment with a secretKeyRef for the value causes flagger to get into an infinite loop restarting the analysis. E.g.:

{"level":"info","ts":"2021-01-15T19:56:22.219Z","caller":"controller/events.go:33","msg":"New revision detected! Restarting analysis for podinfo.test","canary":"podinfo.test"}
{"level":"info","ts":"2021-01-15T19:56:37.160Z","caller":"controller/events.go:33","msg":"New revision detected! Restarting analysis for podinfo.test","canary":"podinfo.test"}
{"level":"info","ts":"2021-01-15T19:56:52.161Z","caller":"controller/events.go:33","msg":"New revision detected! Restarting analysis for podinfo.test","canary":"podinfo.test"}
{"level":"info","ts":"2021-01-15T19:57:07.128Z","caller":"controller/events.go:33","msg":"New revision detected! Restarting analysis for podinfo.test","canary":"podinfo.test"}
{"level":"info","ts":"2021-01-15T19:57:22.129Z","caller":"controller/events.go:33","msg":"New revision detected! Restarting analysis for podinfo.test","canary":"podinfo.test"}
{"level":"info","ts":"2021-01-15T19:57:37.105Z","caller":"controller/events.go:33","msg":"New revision detected! Restarting analysis for podinfo.test","canary":"podinfo.test"}
{"level":"info","ts":"2021-01-15T19:57:52.107Z","caller":"controller/events.go:33","msg":"New revision detected! Restarting analysis for podinfo.test","canary":"podinfo.test"}
{"level":"info","ts":"2021-01-15T19:58:07.059Z","caller":"controller/events.go:33","msg":"New revision detected! Restarting analysis for podinfo.test","canary":"podinfo.test"}
{"level":"info","ts":"2021-01-15T19:58:22.058Z","caller":"controller/events.go:33","msg":"New revision detected! Restarting analysis for podinfo.test","canary":"podinfo.test"}
{"level":"info","ts":"2021-01-15T19:58:37.036Z","caller":"controller/events.go:33","msg":"New revision detected! Restarting analysis for podinfo.test","canary":"podinfo.test"}

[vorozhko]

Hi @kyanagimoto and @stefanprodan , this is still a blocker for us.
New 1.6.1 doesn't fix the described issue for us.
We install flagger using helm.

[stefanprodan]

@vorozhko you need to update the CRDs, Helm doesn't do that.

[vorozhko]

Works after CRD update.
Thank you!