Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP 4xx req percentage threshold to canary analysis checks #8

Closed
stefanprodan opened this issue Nov 26, 2018 · 0 comments
Closed

Add HTTP 4xx req percentage threshold to canary analysis checks #8

stefanprodan opened this issue Nov 26, 2018 · 0 comments
Labels
kind/feature Feature request

Comments

@stefanprodan
Copy link
Member

The request success check takes into account only HTTP 5xx. A new metric could be added that would target 4xx status codes. This implies renaming the success rate metric in the CRD to have a clear distinction between 5xx and 4xx.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefanprodan