Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Support git checkout over http proxy #2179

Closed
davidkarlsen opened this issue Jun 23, 2019 · 2 comments · Fixed by #2279
Closed

Support git checkout over http proxy #2179

davidkarlsen opened this issue Jun 23, 2019 · 2 comments · Fixed by #2279

Comments

@davidkarlsen
Copy link
Contributor

davidkarlsen commented Jun 23, 2019

Describe the feature
See https://gitolite.com/git-over-proxy.html
If socat could be included in the image then checkout against github would be supported for environments locked down behind a corporate proxy. This would also mean exposing an option to configure /root/.ssh/config via the helm-chart.

What would the new user story look like?
How would the new interaction with Flux look like? E.g.
0. install flux

  1. configure ssh-config to use socat

Feel free to add a diagram if that helps explaining things.

Expected behavior
Checkouts would go via http-proxy

@davidkarlsen davidkarlsen added blocked-needs-validation Issue is waiting to be validated before we can proceed enhancement labels Jun 23, 2019
@davidkarlsen davidkarlsen changed the title Support git checkout over http proxy Support git checkout over http proxy by using socat Jun 23, 2019
@davidkarlsen
Copy link
Contributor Author

Another option would be to checkout over https as normally but support username + token as described in https://help.github.com/en/articles/creating-a-personal-access-token-for-the-command-line

@davidkarlsen davidkarlsen changed the title Support git checkout over http proxy by using socat Support git checkout over http proxy Jun 23, 2019
@hiddeco
Copy link
Member

hiddeco commented Jun 24, 2019

Besides to adding socat, the GIT_PROXY_COMMAND environment variable also needs to be whitelisted.

https://github.com/weaveworks/flux/blob/master/git/operations.go#L28

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants