Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Deal with images for another arch/OS #999

Closed
squaremo opened this issue Mar 12, 2018 · 3 comments
Closed

Deal with images for another arch/OS #999

squaremo opened this issue Mar 12, 2018 · 3 comments

Comments

@squaremo
Copy link
Member

squaremo commented Mar 12, 2018

Some image repositories have images available for architectures other than amd64/Linux. We explicitly omit these from results, but our fetching logic means that we'll go looking for exactly the same image metadata next time around.

There are two problems:

  • Not getting metadata for certain tags means we can't have a result at all. We need to be able to assemble a result from just the relevant tags.
  • We persist in attempting to fetch the results again and again. Similarly to Back-off failed image metadata fetches #910, it would be good to store something saying "just ignore this tag from now on", so that we don't keep trying to fetch it.

Possibly we could fix both of these things by storing the result whatever it is, and filtering out the wrong arch/OS when assembling the result.

@rade
Copy link
Contributor

rade commented Mar 12, 2018

Is this a dup of #741?

@squaremo
Copy link
Member Author

Hmm yeah I had forgotten that one. Though #851 fixed many of the issues around fetching image metadata, including being able to handle fat manifests (like the example there has), we still have the symptom that we can't give an ListImages response for e.g., NATS. I'll put my suggestion from above in the issue instead.

@squaremo
Copy link
Member Author

Closing as duplicate of #741.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants