flux seems to struggle with UTF-16 LE encoded files written from Windows PowerShell

[stealthybox]

In TGIK #149 @ 1h23m kustomize-controller reported failing to decode Kubernetes YAML due to "invalid UTF-16 characters", but in VSCode the file looks to display as a valid YAML file.

Windows PowerShell redirects (echo hi > ./file) write files as UTF-16 LE.

We should write test-cases to ensure that files with reasonable encodings work with our controllers.

This particular case may be unique to kustomize-controller, but we should verify that our other controllers don't also break.

---

The PowerShell workaround to write UTF-8 files is like so:

echo hello | out-file -encoding utf8 hi.txt

source: https://superuser.com/questions/327492/default-powershell-to-emitting-utf-8-instead-of-utf-16

[stealthybox]

I am able to reproduce this by adding a UTF-16 LE encoded YAML containing a Kubernetes Service for podinfo to my bootstrap directory:

flux get kustomizations
NAME            READY   MESSAGE                                                                       
                        REVISION                                        SUSPENDED
flux-system     False   kustomize create failed: failed to decode Kubernetes YAML from /tmp/flux-system466986746/clusters/cluster0/default/podinfo-svc.yaml: error converting YAML to JSON: yaml: incomplete UTF-16 character       main/ceb3e29fff0e495e17bbc3da6c5d74c80bb7e498   False

[hiddeco]

https://github.com/fluxcd/kustomize-controller/blob/5f966d0ff615658dc630a89837abeb1bf459d75a/controllers/kustomization_generator.go#L195-L197

We inherit this issue from Kustomize, which inherits it from go-yaml/yaml.