-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications - information content and filtering of info alerts #710
Comments
One thing that would help here is my suggestion in fluxcd/pkg#56 (comment) |
I don't think so, @tbomberg want's to filter the info notifications not Kubernetes events.
The controller-name shows up as the username, see https://toolkit.fluxcd.io/_files/slack-info-alert.png
This is a bug tracked in fluxcd/kustomize-controller#236
Flux1 GC is very different to Flux2 GC. The v2 GC tracks objects without querying the Kubernetes API for each Kind, this means GC can be run under a restricted service account with no cluster wide access (unlike v1 that needs a cluster role binding). |
Unfortunately using the MS-Teams provider the username is always the name of the Incoming Webhook that is used for this, so I would need to create a separate webhook + provider for every controller, but that would be a workaround. |
There is a summary field that you can set in the Alert object, this can be anything: the controller name, cluster name, region, zone, some other id. Would this work for you? |
Ok this adds this part of information, but honestly it does not look nice. There I would rather go for adding webhooks. But what about prefixing the resource name with the kind: e.g. kustomization/prometheus-stack.flux-system |
Please create an issue in notification-controller for this. |
Hi,
I am currently working on the migration of our flux(v1)/helm-operator setups to flux(v2)/Toolkit.
regarding notifications i am struggling to get a reasonable configuration regarding of information and volume.
With flux(v1) we use the (--connect) functionality together with
fluxcloud
to post informational messages to a Teams channel, we created for each cluster.With flux(v1) the message regarding the sync o a git commit contains
I found the information content of these alerts very valuable.
Now with flux2 it seems that I will be missing some of this information.
I do get error information from the controllers if something went wrong.
That is fine, maybe even more then before since Helm is covered as well.
The repeating alerts on retries are limiting the usability as already mentioned in this discussion #661 .
But for the info messages I am currently missing some valuable information
Nothing about the change itself
I have seen in Slack notification is misleading #626 , that it has to be that way, but how did flux(v1) manage get get this information out even with GC enabled.
Did I overlook something? Is the information available but just hidden by the provider?
Can we get closer to the former message value?
One thing I would suggest is to add some kind of filter for the info events, either by name or
to classify into read/write operations.
Also currently the alerts show no information of the kind of toolkit object (or controller) they come from (e.g. GitRepository or Kustomization), just the name.namespace. This might be a nice add.
The text was updated successfully, but these errors were encountered: