Overrides helms default value for WaitForJobs

[imduffy15]

By default helm sets WaitForJobs to false, however, when using helm controller this field becomes true. This feels unexpected.

On helm controller a field of DisableWaitForJobs is present, this is a golang boolean which is false by default, however, when converted over to the WaitForJobs field of a helm rollback/update/install object the field is negated, that is !false which becomes true. That is, the default false for DisableWaitForJobs results in a true WaitForJobs which on helm is false by default.

Ref: https://github.com/fluxcd/helm-controller/blob/main/internal/runner/runner.go#L112

[hiddeco]

This is by design, as we also enable --wait by default to ensure we provide users with the best automated experience. As without these defaults, any job failures would go unnoticed. Ref: #271 (review)

Note that the goal of the HelmRelease API is not to be a 1:1 mapping of default Helm flags, but rather sane declarative configuration for continuous deployments and automation.