Unnecessary conditions in the code

[dholbach]

From Ada Logics

In the following code, the auto.Spec.Update is not needed, and if indeed auto.Spec.Update was nil then the first conditional statement would be panic due to a nil-dereference.

image-automation-controller/controllers/imageupdateautomation_controller.go

Lines 253 to 264 in 7ec4e61

	manifestsPath := tmp
	if auto.Spec.Update.Path != "" {
	tracelog.Info("adjusting update path according to .spec.update.path", "base", tmp, "spec-path", auto.Spec.Update.Path)
	if p, err := securejoin.SecureJoin(tmp, auto.Spec.Update.Path); err != nil {
	return failWithError(err)
	} else {
	manifestsPath = p
	}
	}
	switch {
	case auto.Spec.Update != nil && auto.Spec.Update.Strategy == imagev1.UpdateStrategySetters:

Recommendation
Remove unnecessary code.

[Nalum]

I'd like to take up this issue if that's good with you