Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cross-namespace sourceRef in ImageUpdateAutomation #294

Closed
squaremo opened this issue Jan 19, 2022 · 4 comments · Fixed by #299
Closed

Support cross-namespace sourceRef in ImageUpdateAutomation #294

squaremo opened this issue Jan 19, 2022 · 4 comments · Fixed by #299

Comments

@squaremo
Copy link
Member

For some deployments of Flux, the GitRepository object giving access to a git repo is owned by one team, and the definitions for image updates (ImageRepository, ImagePolicy, and ImageUpdateAutomation) are owned by other teams. There is a strong preference in those cases for keeping the GitRepository in one namespace, and letting teams define automation in their own namespaces -- but to be able to do that, the ImageUpdateAutomation object would need to be able to refer to a GitRepository object in another namespace.

Similar work was done in fluxcd/image-reflector-controller#162, and for more background on similar use cases, see #85.

(I am not going to recapitulate the pros and cons of breaking namespace isolation here -- that ship has sailed meaning.)

@aryan9600
Copy link
Member

aryan9600 commented Jan 20, 2022

Looking at fluxcd/image-reflector-controller#162, do we want to add similar ACL support or let ImageUpdateAutomation objects in any namespace have access to a GitRepository?

@squaremo
Copy link
Member Author

do we want to add similar ACL support or let ImageUpdateAutomation objects in any namespace have access to a GitRepository?

Good question. I would feel more comfortable waiting for accessFrom to be implemented in source controller, then respecting it here.

@stefanprodan
Copy link
Member

stefanprodan commented Jan 20, 2022

Good question. I would feel more comfortable waiting for accessFrom to be implemented in source controller, then respecting it here.

ACLs are client-side, as described in fluxcd/flux2#2092, we do have the SC APIs with ACLs released.

@stefanprodan
Copy link
Member

@squaremo according to fluxcd/flux2#2093 this controller should accept cross-namespace refs as KC and HC do now. When that RFC is merged, only then we can add a flag to enforce ACLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants