Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document GC checksum annotation #365

Merged
merged 4 commits into from
Jun 14, 2021
Merged

Document GC checksum annotation #365

merged 4 commits into from
Jun 14, 2021

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Jun 14, 2021 •
edited
Loading

Changes:

  • refactor GC tests
  • add test for skipping GC when spec.prune is disabled
  • add test for skipping GC when the kustomize.toolkit.fluxcd.io/prune label is set to disabled
  • update the API spec docs with the GC checksum annotation
  • Add missing RBAC for ConfigMap read-only access

Followup: #362

@stefanprodan
Add missing ConfigMap RBAC
f8cac4a 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Add test for GC disabling
2d85398 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Simplify staleness check
24f78af 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan
Document the checksum annotation
7772a1f 
Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the area/docs Documentation related issues and pull requests label Jun 14, 2021
@stefanprodan stefanprodan requested a review from hiddeco June 14, 2021 10:58
@stefanprodan stefanprodan merged commit cdabadb into main Jun 14, 2021
@stefanprodan stefanprodan deleted the gc-tests-docs branch June 14, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiddeco hiddeco hiddeco approved these changes

Assignees
No one assigned
Labels
area/docs Documentation related issues and pull requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanprodan @hiddeco