Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notification-controller to new unified standards #251

Closed
scottrigby opened this issue Aug 3, 2021 · 1 comment · Fixed by #243
Closed

Update notification-controller to new unified standards #251

scottrigby opened this issue Aug 3, 2021 · 1 comment · Fixed by #243

Comments

@scottrigby
Copy link
Member

This issue is to track rolling out the changes to Notification Controller.

This controller is sufficiently complex to make exemplary use of pkg/runtime, specifically it's primary purpose which is move conditions logic to a reusable package. Once this is updated, it should help steer the way for a wider group to roll these standards out to the other controllers.

@stefanprodan
Copy link
Member

@scottrigby please open these in each controller repo, I moved the helm one.

@stefanprodan stefanprodan changed the title Update notification-controller to new unified standards in progress Update notification-controller to new unified standards Oct 1, 2021
@stefanprodan stefanprodan transferred this issue from fluxcd/flux2 Oct 1, 2021
@stefanprodan stefanprodan linked a pull request Oct 1, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants