Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Create auto gitImplementation #333

Closed
Tracked by #3039
pjbgf opened this issue Aug 25, 2022 · 2 comments
Closed
Tracked by #3039

git: Create auto gitImplementation #333

pjbgf opened this issue Aug 25, 2022 · 2 comments
Labels
area/git Git and SSH related issues and pull requests help wanted Extra attention is needed
Milestone

Comments

@pjbgf
Copy link
Member

pjbgf commented Aug 25, 2022

Flux supports two git implementations: libgit2 and go-git. They do not have feature parity, which the two main problems being:

  • Shallow clones is only supported by go-git. Which results in less data being transmitted through the network at every clone operation.
  • Git V2 Protocol is only supported by libgit2. Servers that only support this protocol (e.g. Azure DevOps) won't work with go-git.

We should build a third git implementation type (a.k.a auto), which removes the need from users to understand the difference between the implementations, and always try to use whichever is the most optimal.

On a high-level, the new implementation could take into account:

  • Server fingerprint: query the SSH banner and HTTP headers.
  • Protocol Awareness: find ways to identify what Git protocol version is being used, which may be easier over HTTP scheme.
@pjbgf pjbgf added the area/git Git and SSH related issues and pull requests label Aug 25, 2022
@pjbgf pjbgf added this to the GA milestone Aug 25, 2022
@pjbgf pjbgf added the help wanted Extra attention is needed label Aug 25, 2022
@aryan9600
Copy link
Member

I think we should close this issue as we have removed the libgit2 git implementation from both source-controller and image-automation-controller.

@pjbgf
Copy link
Member Author

pjbgf commented Jan 5, 2023

Agreed, closing it. 👍

@pjbgf pjbgf closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git and SSH related issues and pull requests help wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

2 participants