Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move MergeMaps to pkg #84

Closed
arbourd opened this issue Feb 13, 2021 · 3 comments · Fixed by #85
Closed

Move MergeMaps to pkg #84

arbourd opened this issue Feb 13, 2021 · 3 comments · Fixed by #85

Comments

@arbourd
Copy link
Contributor

arbourd commented Feb 13, 2021 •
edited
Loading

As per https://github.com/fluxcd/flux2/blob/v0.8.0/internal/utils/utils.go#L403-L404, MergeMaps should be abstracted and moved to pkg.

What / where would be a good place for this function?

It will most likely be used by:

  • flux2
  • helm-controller
  • source-controller
@hiddeco
Copy link
Member

hiddeco commented Feb 13, 2021 •
edited
Loading

When moving, the version from helm-controller should be used as this one is the most complete with regard to comments and origin reference.

The best place for this util function is likely a package in runtime.

https://github.com/fluxcd/helm-controller/blob/401f6a2c51e412cfdd11ddf19f8248b21f257171/internal/util/util.go#L29-L51

@arbourd arbourd mentioned this issue Feb 13, 2021
Merged
@arbourd
Copy link
Contributor Author

arbourd commented Feb 15, 2021

I can update the transitive dependencies once this is released in runtime 😁

@hiddeco
Copy link
Member

hiddeco commented Feb 15, 2021

@arbourd made available in v0.8.2, thank you! 🌻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move MergeMaps from helm-controller
2 participants
@arbourd @hiddeco