Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decommission usage Artifact.Checksum field #1024

Closed
3 tasks
Tracked by #947
hiddeco opened this issue Feb 14, 2023 · 0 comments
Closed
3 tasks
Tracked by #947

Decommission usage Artifact.Checksum field #1024

hiddeco opened this issue Feb 14, 2023 · 0 comments
Labels
area/storage Storage related issues and pull requests enhancement New feature or request
Milestone

Comments

@hiddeco
Copy link
Member

hiddeco commented Feb 14, 2023

In #1001 the Artifact.Checksum field has been deprecated in favor of the newly introduced Artifact.Digest. This PR itself did not decommission the usage of the field throughout the controller itself, as the controller may be backed by a Persistent Volume which would not cause it to produce a digest until a new artifact has been stored, allowing a transition period to exist.

Full deprecation of this field could either be done in a single stage in which we remove the Checksum field from the Artifact and start working solely with the Digest. Or we can opt to first check if a Digest is present before falling back to the Checksum, while not removing the field yet from the API.

Internals

  • Use Digest when available, optionally falling back to Checksum

API facing

  • Remove Checksum field from Artifact
  • Remove calculation of SHA-256 sum on storage of Artifact

xref: #1001 (comment)

@hiddeco hiddeco added enhancement New feature or request area/storage Storage related issues and pull requests labels Feb 14, 2023
@stefanprodan stefanprodan added this to the Bootstrap GA milestone Mar 22, 2023
@hiddeco hiddeco closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/storage Storage related issues and pull requests enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants