Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bucket: generic bucket provider support custom url lookup type #1199

Closed
zhiyu0729 opened this issue Aug 15, 2023 · 1 comment · Fixed by #1211
Closed

Bucket: generic bucket provider support custom url lookup type #1199

zhiyu0729 opened this issue Aug 15, 2023 · 1 comment · Fixed by #1211

Comments

@zhiyu0729
Copy link
Contributor

zhiyu0729 commented Aug 15, 2023 •
edited
Loading

The bucket provider I am currently using is Alibaba Cloud's oss, which is an object storage compatible with the S3 protocol. But OSS only supports virtual hosted style access to buckets. I see that the lookup method of the bucket is hard-coded now

source-controller/pkg/minio/minio.go

Line 43 in 36ca723

BucketLookup: minio.BucketLookupPath,

This makes it impossible to use it with oss.

I think we can use auto lookup type or add bucket.Spec.LookupType to Bucket api to make it configurable
@yusupovazubaljat
Copy link

very good

@zhiyu0729 zhiyu0729 mentioned this issue Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bucket: Use auto lookup type zhiyu0729/source-controller
2 participants
@zhiyu0729 @yusupovazubaljat