Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set observedGeneration under condition Ready #362

Closed
kishoregv opened this issue May 17, 2021 · 1 comment · Fixed by #586
Closed

Set observedGeneration under condition Ready #362

kishoregv opened this issue May 17, 2021 · 1 comment · Fixed by #586

Comments

@kishoregv
Copy link

kishoregv commented May 17, 2021 •
edited
Loading

Currently, observedGeneration is only set in status level for gitrepository resource. It would be helpful to set observedGeneration under conditions as well. To reliably rely on kubectl wait command for ready condition to be met.

If the previous condition was ready for gitrepository resource then, sometime kubectl wait will confirm to soon as condition met based on previous Ready condition.

observedGeneration can be set to all conditions of all Kinds
@hiddeco
Copy link
Member

hiddeco commented May 17, 2021

This is being worked on in fluxcd/pkg#101 and #361

@hiddeco hiddeco mentioned this issue Feb 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move to v1beta2 API and rewrite reconcilers fluxcd/source-controller
2 participants
@kishoregv @hiddeco