Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unknown build error when reconciling HelmChart from an OCI Registry #894

Open
souleb opened this issue Sep 9, 2022 · 6 comments
Open
Assignees
Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests bug Something isn't working good first issue Good for newcomers

Comments

@souleb
Copy link
Member

souleb commented Sep 9, 2022

HelmCharts reconciliation sometime result in unknown build error and Unknown reason with auth failure It happens when HelmChart build is attempted when the associated HelmRepository isn't ready because of the auth failure.
It then returns *conditions.TrueCondition(sourcev1.FetchFailedCondition, "Unknown", "unknown build error: failed to login to OCI registry").

Around source-controller/controllers/helmchart_controller.go we have a check for non-OCI charts to ensures that the HelmRepo has artifact before proceeding further. We can add a similar check for OCI where we make sure that the HelmRepo is ready before proceeding to build it. That way, we can avoid such Unknown errors and show better status conditions.

@souleb souleb added bug Something isn't working good first issue Good for newcomers area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests labels Sep 9, 2022
@Santosh1176
Copy link
Contributor

Santosh1176 commented Oct 8, 2022

Hey @souleb, Can I work on this?

Could you also please point me to some resources for reproducing this locally?
Thanks

@souleb
Copy link
Member Author

souleb commented Oct 10, 2022

Thanks for working on this @Santosh1176

If you create a helmrepository of type oci with wrong credentials, it should fail reconciliation. If you then use it as source in a helmrelease, you should be able to reproduce. You will have to look for the helmChart custom resource declared by the helm-controller.

@souleb
Copy link
Member Author

souleb commented Nov 23, 2022

hello @Santosh1176, did you have the chance to look at this?

@Santosh1176
Copy link
Contributor

@souleb Sorry, I tried but could not reproduce the issue, I'll take a closer look this weekend. if this task is of importance, please go ahead.
Thank you!

@souleb
Copy link
Member Author

souleb commented Mar 14, 2023

I think we can close this? cc @darkowlzz

@darkowlzz
Copy link
Contributor

@souleb I don't remember any fix for this and looking at the code, I don't see any check for OCI HelmRepository to be ready. So it should still be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Helm related issues and pull requests area/oci OCI related issues and pull requests bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants