Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

saving when hard drive being full corrupts the note file. #903

Open
Midou36O opened this issue Nov 26, 2023 · 1 comment · May be fixed by #1370
Open

saving when hard drive being full corrupts the note file. #903

Midou36O opened this issue Nov 26, 2023 · 1 comment · May be fixed by #1370
Labels
bug Something isn't working

Comments

@Midou36O
Copy link

Midou36O commented Nov 26, 2023 •
edited
Loading

Describe the bug
Having the hard drive filled up. Can cause rnote to automatically inform you that the save failed and corrupts the saved file after informing you. If you keep the file open, you can save it and recover it, but once it's closed. It's gone.

To Reproduce
Steps to reproduce the behavior:

  1. Open a rNote file, and save it, maybe add some scribbles. and save it afterwards.
  2. Use any program to fill up the hard drive, or a virtual disk. Tools like dd (I will not describe the command, to avoid unexpected accidents.) can help you easily fill the drive.
  3. Wait for rNote to automatically save the note, or manually trigger the save.
  4. See rNote informing you of having failed to save the file. Corrupting your file while informing you and treating the currently opened file as a draft.

Expected behavior
An error should inform you of the problem, but shouldn't corrupt your file.

Console Output

command > RUST_LOG=rnote=debug RUST_BACKTRACE=1 rnote
 2023-11-26T18:54:22.096Z DEBUG rnote > ... env_logger initialized

(rnote:17707): Gtk-CRITICAL **: 19:54:22.843: gtk_widget_class_set_accessible_role: assertion '!gtk_accessible_role_is_abstract (accessible_role)' failed

(rnote:17707): Gtk-WARNING **: 19:54:23.666: Creating a portal monitor failed: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: L’interface « org.freedesktop.portal.Inhibit » n’existe pas pour l’objet à l’emplacement /org/freedesktop/portal/desktop
 2023-11-26T18:54:31.389Z DEBUG rnote::canvas > canvas with title: `exemple` - output-file monitor emitted `changed` - file: Some("/home/midou/Documents/rNote/.goutputstream-UEZ4E2"), other_file: Some(Some("/home/midou/Documents/rNote/exemple.rnote")), event: Renamed, expect_write: true
 2023-11-26T18:55:27.323Z DEBUG rnote::canvas > canvas with title: `exemple` - output-file monitor emitted `changed` - file: Some("/home/midou/Documents/rNote/.goutputstream-H866E2"), other_file: Some(Some("/home/midou/Documents/rNote/exemple.rnote")), event: Renamed, expect_write: true

(rnote:17707): dconf-WARNING **: 19:55:32.995: failed to commit changes to dconf: GDBus.Error:org.gtk.GDBus.UnmappedGError.Quark._g_2dfile_2derror_2dquark.Code12: Failed to write file “/home/midou/.config/dconf/user.0AQDF2”: write() failed: No space left on device
 2023-11-26T18:55:39.627Z ERROR rnote::appwindow::appwindowactions > saving document failed, Error: `output_stream write_all_future() failed in create_replace_file_future(), Err: Error { domain: g-io-error-quark, code: 12, message: "Erreur lors de l’écriture du fichier\u{a0}: Aucun espace disponible sur le périphérique" }`
 2023-11-26T18:55:39.630Z ERROR rnote::overlays                    > Échec de l'enregistrement du document

(rnote:17707): dconf-WARNING **: 19:55:42.991: failed to commit changes to dconf: GDBus.Error:org.gtk.GDBus.UnmappedGError.Quark._g_2dfile_2derror_2dquark.Code12: Failed to write file “/home/midou/.config/dconf/user.O6QDF2”: write() failed: No space left on device

The OS is in french, but the general translation just says an error happened while writing the file and that there is no more space available.

Screenshots
N/A

Desktop (please complete the following information):

  • OS: Artix Linux / Arch Based distro.
  • App Version: rNote 0.9.2
  • Installation Source: Arch Community Repo
  • Desktop Environment: Sway (Wayland)

Additional context
N/A
@flxzt flxzt added the bug Something isn't working label Nov 30, 2023
@flxzt flxzt changed the title Hard drive being full corrupts the note file. saving when hard drive being full corrupts the note file. Nov 30, 2023
Midou36O added a commit to Midou36O/rnote that referenced this issue Feb 25, 2025
@Midou36O
fix: Write in a temp file before replacing the original file, fixes f…
e610b88 
…lxzt#903
@Midou36O Midou36O linked a pull request Feb 25, 2025 that will close this issue
Open
@Doublonmousse
Copy link
Collaborator

Linked to #1128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Write in a temp file before replacing the original file, fixes #903 Midou36O/rnote
3 participants
@flxzt @Midou36O @Doublonmousse