feat: implement react hooks BREAKING CHANGE #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fede
approved these changes
Feb 13, 2019
added 8 commits
February 23, 2019 14:32
lfantone
changed the title
crash7
reviewed
Feb 25, 2019
Co-Authored-By: lfantone <lfantone@users.noreply.github.com>
lfantone
changed the title
flybondi-nelson
added a commit
that referenced
this pull request
Mar 10, 2019
# [3.0.0](v2.1.0...v3.0.0) (2019-03-10) ### Features * implement react hooks BREAKING CHANGE ([#17](#17)) ([1892340](1892340)) ### BREAKING CHANGES * Uses latest release of react, as the implementation was refactored to use Hooks. Also the querystring is now being pass as a page prop under query.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation was to reduce as much as possible all renders between pages.
Also, what I did was to stop rendering the next page until the intial props are fetched (that's why there are a couple of effects declared). My suggestion is to wrapped all pages component that will use
Beforewith react.memo.React.memo is just a sugar syntax for using the
componentShouldUpdatelifecycle with a functional component.Finally, there was an issue with the
querystringnot being pass in server-side because thematchprops was being override it with the original react router match. There is an strange behaviour with the lambda and react-router not populating thelocation.searchprop properly, I have no idea why 🤔 .In order to use this version of before, you must update react to latest.
BREAKING CHANGE: Uses latest release of react, as the implementation was refactored to use Hooks. Also the
querystringis now being pass as a page prop under query.