-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add routes and files #852
Conversation
This PR is being prevented from merging because Review Required. Use the Approved label to run build validation and auto merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things but to start thanks for continuing work on this.
Minor Notes
- We have a WIP directory that includes some A380 flight ops information. If you can move the entirety of your PR's contents to that folder and keep your structure for easy moving later that would be great as we aren't ready to publish this info just yet but I would gladly have this on the repo.
- For the above when we update our installation in the coming days you can most likely leave your documentation where it is and we can exclude it from the active build until the A380 is ready OR we have other ideas of when exactly to present this information.
- If you'd like to refactor / update the existing information alongside yours that would be helpful otherwise we can leave that for a later time.
Critical
- Your images are too large and do not conform to our standards.
- See Image Assets Process on our guide.
![QTR Routes](../../../fbw-a38nx/assets/routes/qtrroutes.jpg "QTR Routes") | ||
|
||
### **Currently operating** | ||
| Departure ICAO/IATA | Arrival ICAO/IATA | Flight Number | Lenght | Distance | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Departure ICAO/IATA | Arrival ICAO/IATA | Flight Number | Lenght | Distance | | |
| Departure ICAO/IATA | Arrival ICAO/IATA | Flight Number | Length | Distance | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although I would suggest changing "Length" -> "Duration" // as that would make more sense in aviation to me.
Additionally, length is misspelled in each document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll have to correct the units. I can make a review with suggestions in the coming days, but here is essentially what has to be changed.
- Between the numbers and the respective units you should insert a non-breakable space (alt+0160 on windows).
- the unit for nautical miles is upper case, so NM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This as an example, please change the others accordingly and don't forget to format the tables.
--- | ||
|
||
## ^^Fleet^^ | ||
Asiana Airways has 6 A380s in it's fleet first delivered in December 2013 and last on August 2016 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asiana Airways has 6 A380s in it's fleet first delivered in December 2013 and last on August 2016 | |
Asiana Airways has 6 A380 in its fleet first delivered in December 2013 and last on August 2016 | |
--- | ||
|
||
## ^^Routes^^ | ||
Asiana is currently operating their A380s on 3 routes around the world. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Asiana is currently operating their A380s on 3 routes around the world. | |
Asiana is currently operating their A380 on 3 routes around the world. | |
| Departure ICAO/IATA | Arrival ICAO/IATA | Flight Number | Lenght | Distance | | ||
|:--------|:--------|:------|:------|:-----| | ||
| RKSI/ICN | VTBS/BKK | OZ741 | 5h15m | 1980nm | | ||
| VTBS/BKK | RKSI/ICN | OZ742 | 4h40m | 1980nm | | ||
| RKSI/ICN | YSSY/SYD | OZ601 | 10h00m | 4550nm | | ||
| YSSY/SYD | RKSI/ICN | OZ602 | 10h10m | 4550nm | | ||
| RKSI/ICN | KLAX/LAX | OZ202 | 10h10m | 5210nm | | ||
| KLAX/LAX | RKSI/ICN | OZ201 | 12h55m | 5210nm | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Departure ICAO/IATA | Arrival ICAO/IATA | Flight Number | Lenght | Distance | | |
|:--------|:--------|:------|:------|:-----| | |
| RKSI/ICN | VTBS/BKK | OZ741 | 5h15m | 1980nm | | |
| VTBS/BKK | RKSI/ICN | OZ742 | 4h40m | 1980nm | | |
| RKSI/ICN | YSSY/SYD | OZ601 | 10h00m | 4550nm | | |
| YSSY/SYD | RKSI/ICN | OZ602 | 10h10m | 4550nm | | |
| RKSI/ICN | KLAX/LAX | OZ202 | 10h10m | 5210nm | | |
| KLAX/LAX | RKSI/ICN | OZ201 | 12h55m | 5210nm | | |
| Departure ICAO/IATA | Arrival ICAO/IATA | Flight Number | Length | Distance | | |
|:--------|:--------|:------|:------|:-----| | |
| RKSI/ICN | VTBS/BKK | OZ741 | 5 h 15 m | 1980 NM | | |
| VTBS/BKK | RKSI/ICN | OZ742 | 4 h 40 m | 1980 NM | | |
| RKSI/ICN | YSSY/SYD | OZ601 | 10 h 00 m | 4550 NM | | |
| YSSY/SYD | RKSI/ICN | OZ602 | 10 h 10 m | 4550 NM | | |
| RKSI/ICN | KLAX/LAX | OZ202 | 10 h 10 m | 5210 NM | | |
| KLAX/LAX | RKSI/ICN | OZ201 | 12 h 55 m | 5210 NM | | |
@D0m1nu2 is there any update on this PR? |
I'm sorry for my recent inactivity, I did not have much time to look into this due to big amount of work. I will try to find some more time in the upcoming weeks so I fix and add all the mentioned things. |
No worries -- just wanted to check in! I have updated my review regarding the WIP directory and whenever you are ready for review I might simply add a few commits to ensure your documentation is appropriately setup if it's out of scope for you. Either way thanks again for doing this good stuff. |
Outdated |
Summary
Add A380 active routes overview for FBW website. Currently I've only made few of them to see if it's ok like this, once I got confirmation, I will finish the rest of them.
I've used FlightRadar24 for route length and average flight time, then Planespotter for fleet info.
Location
docs/fbw38nx/xxx
Discord username (if different from GitHub): D0m1nuZ @D0m1nu2