-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bullet gem pulls the latest dependency of "Uniform Notifier" which dropped support for Growl. #617
Comments
@granowski-bamboo I don't know what patch do you expect, I just updated README to say
|
A co-worker suggested I open as issue cause the expectation is that usually dependencies are pinned with versions along with semantic versioning expectations. We didn't expect that the uniform_notifier would drop growl support and break our code (which only references the bullet library directly). I think we're mostly opening this issue just to let you know that people's ruby apps will break randomly because the uniform_notifier dependency will upgrade itself if the dependency is not locked down to version approximately 1.14.x. |
Line 28 in 96e66d1
I imagine that needs to say And in version 7+'s branch you could have something like |
I honestly don't know what the answer is here, I'm no rubyist expert... rofl. |
POSTING THIS FOR ANYONE ELSE WHO RUNS ACROSS THIS PROBLEM: I don't use
I just ran
Rails version 6.1.5 Locking bullet to 6 wasn't enough, as my
After this, I deleted There seems to be something in bullet 7.0.1 that is still referencing growl, @flyerhzm . Hope the above stack trace is helpful in isolating and removing it as appropriate! |
@jacob-ablowitz this looks weird, I have removed the growl from both uniform_notifier and bullet. |
When I was running this app I have at this company I work for, we were doing our typical workflow and came across this:
/-----CENSORED-----/config/environments/development.rb:67:in
block (2 levels) in <main>': undefined method
growl=' for Bullet:Module (NoMethodError)Turns out as of about 8 hours ago:
flyerhzm/uniform_notifier@dd6cc19
"drop growl support" was committed to the uniform_notifier library.
When I use version 1.14.2 of uniform_notifier, the app works, the bullet gem is fine.
When I use version 1.16.0 the app startup blows up cause the growl= method is gone.
A simple answer could be to fix the uniform_notifier dependency for bullet.
But it looks like some deprecation is underway, so a new version of bullet probably needs to be released.
We're using bullet gem 6.1.4 in this app I work on.
So I imagine a patch? One that rolls up to the version 7 or something...?
The text was updated successfully, but these errors were encountered: