Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RemoveUnusedMethodsInModelsCheck with define_method #275

Open
gkopylov opened this issue Jul 14, 2016 · 0 comments
Open

RemoveUnusedMethodsInModelsCheck with define_method #275

gkopylov opened this issue Jul 14, 2016 · 0 comments

Comments

@gkopylov
Copy link

There are some false positive when class have methods that defined by define_method. I dig a little deeper and found out that interesting_nodes (https://github.com/railsbp/rails_best_practices/blob/master/lib/rails_best_practices/prepares/model_prepare.rb#L9) doesn't contain any symbols for that. It probably must have :method_add_block, but I can not clear up yet how to fetch method name in this case.

Most likely this issue #273 is bound to that too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gkopylov