Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Expose flyteconsole's ENABLE_GA env var to helm chart #1857

Closed
2 of 5 tasks
EngHabu opened this issue Nov 23, 2021 · 1 comment · Fixed by #2019
Closed
2 of 5 tasks

[Housekeeping] Expose flyteconsole's ENABLE_GA env var to helm chart #1857

EngHabu opened this issue Nov 23, 2021 · 1 comment · Fixed by #2019
Assignees
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@EngHabu
Copy link
Contributor

EngHabu commented Nov 23, 2021

Describe the issue

As part of addressing #1442, Console's PR flyteorg/flyteconsole#244 is adding an environment variable to control whether Google Analytics should be enabled or not. We need to make changes to the deployment charts to:

  • Expose a flag in the values.yaml to control this env var.. Defaults to false
  • Enable the flag by default in values-sandbox
  • Update getting started docs to explain this and tell people how to turn it off.

What if we do not do this?

N/A

Related component(s)

flyte

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@EngHabu EngHabu added the housekeeping Issues that help maintain flyte and keep it tech-debt free label Nov 23, 2021
@EngHabu EngHabu added this to the 0.18.2 milestone Nov 23, 2021
@EngHabu EngHabu self-assigned this Nov 24, 2021
@EngHabu EngHabu modified the milestones: 0.18.2, 0.19.0 - Eagle Dec 1, 2021
@yindia yindia assigned yindia and unassigned EngHabu Jan 4, 2022
@EngHabu
Copy link
Contributor Author

EngHabu commented Jan 4, 2022

Thank you @evalsocket for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants