You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Basically, because flytekit still uses the root logger in some places (like when you just import logging and then use logging.info), users' basicConfig command isn't working.
In [1]: import logging
In [2]: logging.info("fdjs")
In [3]: logging.basicConfig(level=logging.INFO)
In [4]: logging.root.__dict__
Out[4]:
{'filters': [],
'name': 'root',
'level': 30, # Should be 20.
'parent': None,
'propagate': True,
'handlers': [<StreamHandler <stderr> (NOTSET)>],
'disabled': False,
'_cache': {20: False}}
This is because there's logic in basicConfig that will effectively silently fail if any logging call to logging has been made.
The fix is to only use loggers under flytekit.loggers, which is something we should do anyways.
Expected behavior
see above.
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
Yes
Have you read the Code of Conduct?
Yes
The text was updated successfully, but these errors were encountered:
Describe the bug
Please see the slack thread starting at https://flyte-org.slack.com/archives/CNMKCU6FR/p1644863543937919?thread_ts=1641829439.010500&cid=CNMKCU6FR
Basically, because flytekit still uses the root logger in some places (like when you just import logging and then use logging.info), users' basicConfig command isn't working.
This is because there's logic in basicConfig that will effectively silently fail if any logging call to logging has been made.
The fix is to only use loggers under flytekit.loggers, which is something we should do anyways.
Expected behavior
see above.
Additional context to reproduce
No response
Screenshots
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: