-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core feature] Cache Flyte deck #2603
Comments
I am having trouble wrapping my head around this. In the previous PR you mentioned it sounds like we wanted to add another artifact to the dataset in the catalog for flytedecks. I don't see that happening anywhere, am I missing this? These PRs seems to assume that the artifact has a metadata item attached to it for the "deckURI" - this is an alternative approach right? |
Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏 |
Hello 👋, This issue has been inactive for over 9 months and hasn't received any updates since it was marked as stale. We'll be closing this issue for now, but if you believe this issue is still relevant, please feel free to reopen it. Thank you for your contribution and understanding! 🙏 |
Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable. |
Motivation: Why do you think this is important?
We should cache flyte deck in execution, otherwise, FlyteConsole won't display the deck file when the cache is hit
To cache the deck file, we can add
deck_uri
to the new artifact in datacatalog. Therefore, every time we cache the task execution, we'll create two artifacts. one for output literal, another one fordeck_uri
.check more detail here, flyteorg/flytepropeller#443 (comment)
Goal: What should the final outcome look like, ideally?
We can get the deck file from node execution when the cache is hit.
Describe alternatives you've considered
No
Propose: Link/Inline OR Additional context
No response
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: