Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flytekit-java] Add typed transform inputs #3260

Closed
2 tasks done
andresgomezfrr opened this issue Jan 24, 2023 · 1 comment
Closed
2 tasks done

[flytekit-java] Add typed transform inputs #3260

andresgomezfrr opened this issue Jan 24, 2023 · 1 comment
Labels
enhancement New feature or request flytekit-java Flytekit Java related issue

Comments

@andresgomezfrr
Copy link
Contributor

Motivation: Why do you think this is important?

This feature allows the users to know the specific inputs from a task at development time. This is really important when you are working with a remote task that is developed by other users.

Goal: What should the final outcome look like, ideally?

The final goal is to use the input class in the WorkflowBuilder instead of passing the input into the SdkTransform using the withInput(...) method that forces you to know the attribute names of the input class.

Example

previous way

    SdkNode<SumTask.SumOutput> sumNode =
        builder.apply("fib-3", new SumTask().withInput("fib1", fib1).withInput("fib2", fib2));

new way

    SdkNode<SumTask.SumOutput> sumNode =
        builder.apply("fib-3", new SumTask(), SumTask.SumInput.create(fib1, fib2));

Describe alternatives you've considered

None

Propose: Link/Inline OR Additional context

flyteorg/flytekit-java#175

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@andresgomezfrr andresgomezfrr added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Jan 24, 2023
@narape narape added flytekit-java Flytekit Java related issue and removed untriaged This issues has not yet been looked at by the Maintainers labels Jan 24, 2023
@andresgomezfrr
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request flytekit-java Flytekit Java related issue
Projects
None yet
Development

No branches or pull requests

2 participants