You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Flyteplugins provides default task logging support for Cloudwatch and Stackdriver; however, the links don't include start/finish times. Depending when the links are followed, the user may need to adjust time filters in the log viewer, leading to initial confusion over missing logs and adding an unnecessary step.
Template params for {{ .podUnixStartTime }} and {{ .podUnixFinishTime }} are provided; however. they are incompatible with at least Cloudwatch and Stackdriver. Cloudwatch expects time queries in unix timestamp using millisecond granularity and Stackdriver expects time queries in RFC3339 or ISO 8601 formats.
Goal: What should the final outcome look like, ideally?
Flyte task log links should contain time specific references based on the task's start time (and end time if available).
Describe alternatives you've considered
Require the user to manually filter to the task timeframe
Propose: Link/Inline OR Additional context
One option is to introduce new template params for PodUnixMsecStartTime and PodTimestampStartTime (and their Finish counterparts), corresponding to unix milliseconds and RFC 3339, respectively.
As part of this change we should update the log link to use the container end time if available. Today it is hardcoded to now().
Are you sure this issue hasn't been raised already?
Yes
Have you read the Code of Conduct?
Yes
The text was updated successfully, but these errors were encountered:
Gotemplates support many operators that can unblock these scenarios since, specially with timestamps, it's really hard to provide templates that satisfy all needs (one can argue we should at least support OOB some of these default providers)
This https://coveooss.github.io/gotemplate/docs/basic_features/arithmetic/ can be used to multiply by 1000
Motivation: Why do you think this is important?
Flyteplugins provides default task logging support for Cloudwatch and Stackdriver; however, the links don't include start/finish times. Depending when the links are followed, the user may need to adjust time filters in the log viewer, leading to initial confusion over missing logs and adding an unnecessary step.
Template params for
{{ .podUnixStartTime }}
and{{ .podUnixFinishTime }}
are provided; however. they are incompatible with at least Cloudwatch and Stackdriver. Cloudwatch expects time queries in unix timestamp using millisecond granularity and Stackdriver expects time queries in RFC3339 or ISO 8601 formats.Goal: What should the final outcome look like, ideally?
Flyte task log links should contain time specific references based on the task's start time (and end time if available).
Describe alternatives you've considered
Require the user to manually filter to the task timeframe
Propose: Link/Inline OR Additional context
One option is to introduce new template params for
PodUnixMsecStartTime
andPodTimestampStartTime
(and their Finish counterparts), corresponding to unix milliseconds and RFC 3339, respectively.As part of this change we should update the log link to use the container end time if available. Today it is hardcoded to
now()
.Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: