Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] UI adds spaces to strings inside structs #4052

Closed
2 tasks done
Tracked by #5783 ...
ggydush opened this issue Sep 19, 2023 · 12 comments
Closed
2 tasks done
Tracked by #5783 ...

[BUG] UI adds spaces to strings inside structs #4052

ggydush opened this issue Sep 19, 2023 · 12 comments
Labels
bug Something isn't working

Comments

@ggydush
Copy link

ggydush commented Sep 19, 2023

Describe the bug

When using both dict and dataclass types, the types are represented as a struct in the FlyteConsole. If the struct has a string with commas in it, a space character is added after every comma in the FlyteConsole's Input fields box when launching a workflow (example: "a,b,c" turns into "a, b, c, "). Clicking "Relaunch" adds an additional space as well ("a, b, c, " turns into "a, b, c, ").

Expected behavior

Strings with commas have no added spaces in the FlyteConsole when used within struct types.

Additional context to reproduce

from dataclasses_json import DataClassJsonMixin
from flytekit import task, workflow


@dataclass
class TestClass(DataClassJsonMixin):
    a: str = "this,causes,issues"


@task
def test_task(spec: TestClass) -> None:
    return


@workflow
def test_workflow(spec: TestClass = TestClass()) -> None:
    return test_task(spec=spec)

Screenshots

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@ggydush ggydush added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Sep 19, 2023
@kumare3 kumare3 removed the untriaged This issues has not yet been looked at by the Maintainers label Sep 21, 2023
@shraddhadev24
Copy link

can you please assign this issue to me

@lazyMonk1010
Copy link

hey @ggydush @samhita-alla i want to work on this issue , can you please assign me this!

@samhita-alla
Copy link
Contributor

@shraddhadev24, are you working on this issue?

@shraddhadev24
Copy link

@samhita-alla I need time around. You can assign to @lazyMonk1010

@vaibhav-1508
Copy link

Hey there! Are you still working on this issue @lazyMonk1010 ?
If not, can I be assigned to this issue. Thank you!!🚀

@mecskyverse
Copy link

Hey, @vaibhav-1508 , are you currently working on this issue? It's been a long time since your last follow-up.

@samhita-alla
Copy link
Contributor

@mecskyverse, please feel free to create a PR.

Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@aashish-g03
Copy link

Hi @samhita-alla ,
I noticed that the issue isn't marked as high priority. If it's not an urgent requirement, could you please assign it to me?
I'm still familiarizing myself with open source contributions and would love to take this on. In case I encounter any difficulties, I’ll be sure to let you know so we can reassign if needed.

@samhita-alla
Copy link
Contributor

@aashish-g03 It looks like this issue has already been fixed, sorry about that! Here are the issues that still don't have an assignee: https://github.com/flyteorg/flyte/issues?q=is%3Aopen+is%3Aissue+label%3Ahacktoberfest+no%3Aassignee. If you'd like to contribute to any of these, let us know!

@aashish-g03
Copy link

No problem, @samhita-alla. Could you please assign this issue to me: #5534?

It seems like another beginner-friendly issue I can work on to further familiarize myself with open source contributions.

@samhita-alla
Copy link
Contributor

@aashish-g03 i'm sorry, I can't assign this issue to you as there are already a couple of other requests. however, if you submit a pull request before the others, we'll be happy to merge yours. just keep us posted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants