[BUG] After updating launchplan to a new workflow, breadcrums of execution console shows old workflow name

[GeeCastro]

Describe the bug

When changing a launch plan to a completely new workflow the executions still point to the old workflow. Full conversation on this slack thread https://flyte-org.slack.com/archives/CP2HDHKE1/p1699525138562929?thread_ts=1698914388.559349&cid=CP2HDHKE1

Expected behavior

The execution should show the updated workflow name.

Additional context to reproduce

1. Register a new version of existing launch plan with a new workflow (completely different one, not just a different version of the same workflow)
2. Go to workflows, find the new workflow
3. Click launch and select the launch plan version freshly registered
4. Go to launch plans and select the launch plan
5. Click the execution you just triggered
6. Then at the top of the UI the workflow name will still be the old workflow.

It definitely executes the new workflow though. It’s probably just a UI thing because as expected, neither the execution nor the version are listed in the old workflow but they are in the new workflow.

Screenshots

No response

Are you sure this issue hasn't been raised already?

• Yes

Have you read the Code of Conduct?

• Yes

[dosubot]

🤖

Hi @Chichilele! 👋

I'm Dosu, a friendly bot here to assist while we wait for a human maintainer to join us. I'm here to help you solve bugs, answer questions, and even guide you on how to become a contributor. Just a heads up, despite my vast knowledge, I'm not a human! 😉

Hang tight while we work on this issue together. 🚀

Thank you for reporting this issue. Based on the information provided, it seems like the issue might be related to the caching mechanism in Flyte. Flyte maintains an in-memory cache of all the workflows that are currently executing and their last observed version numbers. When a workflow is updated, the old resource version is cached, which could potentially cause the old workflow name to persist after an update. You can find more details about this in the resourceVersionCaching struct in the flytepropeller/pkg/controller/workflowstore/resource_version_caching.go file.

As for the Flyte UI, it handles the display of launch plan names in the execution console by making HTTP GET requests to the Flyte Admin API. The API endpoint is /api/v1/launch_plan_ids/{project}/{domain}. The UI can specify the number of launch plan names to retrieve using the limit query parameter, and it can sort the results by the name field in either ascending or descending order using the sort_by.key and sort_by.direction query parameters. You can find more details about this in the flyteadmin/tests/launch_plan_test.go file.

However, I wasn't able to find specific information on how the Flyte UI handles updates to the workflow name in the execution console or how it handles the display of workflow names. More information or context would be needed to confirm this.

I hope this information helps. If you have any more details or context that could help us understand the issue better, please share.

Sources

• flytepropeller/pkg/controller/workflowstore/resource_version_caching.go
• flyteadmin/pkg/manager/interfaces/execution.go
• flyteadmin/tests/launch_plan_test.go

---

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

[GeeCastro]

This bot is pretty impressive 😮