Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core feature] Add an option to consider deleted cache as cache miss. #5918

Closed
2 tasks done
amitani opened this issue Oct 25, 2024 · 3 comments
Closed
2 tasks done

[Core feature] Add an option to consider deleted cache as cache miss. #5918

amitani opened this issue Oct 25, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers

Comments

@amitani
Copy link
Contributor

amitani commented Oct 25, 2024

Motivation: Why do you think this is important?

Currently it looks like deleted cache leads to error. The only way to safely delete them is to set max-cache-age and delete cache older than that, or rerun pipeline with cache overwrite. This setting is not very flexible, because it is global.

Goal: What should the final outcome look like, ideally?

If Flyte interprets non-exist cache object as cache miss and rerun the tasks, I can use AWS lifecycle policies which can be more flexible (e.g. delete large cache faster).

Describe alternatives you've considered

More tools around cache management and flexible expiration could be added to Flyte. It was raised in the past but it hasn't been added, and it likely requires much bigger change.

#3305
https://discuss.flyte.org/t/12905332/caching-hey-all-i-rewrote-one-of-my-company-s-critical-workf

Propose: Link/Inline OR Additional context

No response

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@amitani amitani added enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers labels Oct 25, 2024
Copy link

welcome bot commented Oct 25, 2024

Thank you for opening your first issue here! 🛠

@pvditt
Copy link
Contributor

pvditt commented Oct 31, 2024

@eapolinario we have this #4655 that would add an endpoint to delete cache entries

@amitani
Copy link
Contributor Author

amitani commented Nov 1, 2024

The PR is more general and covers my use case. Thank you for pointing it out, and I'm closing this.

@amitani amitani closed this as completed Nov 1, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Flyte Issues/PRs maintenance Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request untriaged This issues has not yet been looked at by the Maintainers
Projects
Status: Done
Development

No branches or pull requests

2 participants