feat: add Desktop release for macOS, Windows & Linux #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
fmaclen
requested changes
Jul 31, 2024
Co-authored-by: Fernando Maclen <fmaclen@gmail.com>
fmaclen
changed the title
fmaclen
requested changes
Aug 4, 2024
There was a problem hiding this comment.
Ended up making some of the changes myself, I spent several hours trying to simplify the workflow and it was a lot easier to just commit my changes directly, so I left you some notes on what changes I made and why.
So far, I only tested the dev and packaged builds on macOS and it works fine.
Next, I will do some QA on the Windows & Linux releases.
After that, I will QA the Github Action in a separate repo to make sure it's all running smoothly.
Tried building a `deb` release but it turned out to be a pain due to x86/arm64 architecture issues
this is so it's easier to identify logging statements from Hollama vs other libraries
…ollama into 64-add-desktop-release
fmaclen
reviewed
Aug 6, 2024
fmaclen
reviewed
Aug 6, 2024
fmaclen
reviewed
Aug 6, 2024
Comment on lines
+21
to
+54
| function checkServerAvailability(port) { | ||
| const MAX_RETRIES = 10; | ||
| const RETRY_INTERVAL_IN_MS = 1000; | ||
|
|
||
| return new Promise((resolve, reject) => { | ||
| let retries = 0; | ||
|
|
||
| function tryConnection() { | ||
| const socket = new net.Socket(); | ||
|
|
||
| const onError = () => { | ||
| socket.destroy(); | ||
|
|
||
| if (retries >= MAX_RETRIES) { | ||
| reject(new Error(`Couldn't connect to Hollama server after ${MAX_RETRIES} attempts`)); | ||
| } else { | ||
| retries++; | ||
| setTimeout(tryConnection, RETRY_INTERVAL_IN_MS); | ||
| } | ||
| }; | ||
|
|
||
| socket.setTimeout(1000); | ||
| socket.once('error', onError); | ||
| socket.once('timeout', onError); | ||
|
|
||
| socket.connect(port, HOLLAMA_HOST, () => { | ||
| socket.destroy(); | ||
| resolve(); | ||
| }); | ||
| } | ||
|
|
||
| tryConnection(); | ||
| }); | ||
| } |
There was a problem hiding this comment.
We use this function to check if the server is ready once per second, up-to 10 times.
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64