feat(i18n): Add Brazilian Portuguese (#214) #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmaclen
requested changes
Oct 16, 2024
There was a problem hiding this comment.
Thanks for submitting the PR 👍
Most of the changes look good, I left you some minor comments below and the test needs to be updated for this new language.
Also, the linter check is failing. Running npm run format && npm run lint on your branch will likely fix the issue.
.github/workflows/test.yml
Outdated
There was a problem hiding this comment.
Our existing CI workflow was miss-configured so I pushed this change to get the tests to run in this branch.
You can ignore it.
|
I made the requested changes, should I close the PR and create and submit a new one? |
fmaclen
approved these changes
Oct 16, 2024
|
🎉 This PR is included in version 0.18.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Brazilian Portuguese Translations.
Thank you for being able to contribute to this wonderful project.
Closes #214