Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): Add Simplified Chinese translations #221

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

SaekiRaku
Copy link
Contributor

@SaekiRaku SaekiRaku commented Oct 22, 2024

This pull request adds Simplified Chinese Translations. resolve the i18n request of #212

图片

图片

@SaekiRaku SaekiRaku changed the title feat(i18n): Add Simplified Chinese feat(i18n): Add Simplified Chinese translations Oct 22, 2024
Copy link
Owner

@fmaclen fmaclen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR!
I think it's good to go 👍

But before we merge, can you remove the commented lines in src/i18n/zh-cn/index.ts?

Comment on lines 62 to 69
// lowVram: '低 VRAM', 个人倾向于技术名词不做翻译,下方注释同理
// mainGpu: '主要 GPU',
messageOfTheDay: '资讯',
messages: '消息',
// minP: 'Min P',
// mirostat: 'Mirostat',
// mirostatEta: 'Mirostat ETA',
// mirostatTau: 'Mirostat Tau',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove the comments in this file.

@SaekiRaku
Copy link
Contributor Author

Thanks for submitting this PR! I think it's good to go 👍

But before we merge, can you remove the commented lines in src/i18n/zh-cn/index.ts?

Done ✅

Copy link
Owner

@fmaclen fmaclen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks again! 🚀

@fmaclen fmaclen merged commit 4e8341e into fmaclen:main Oct 22, 2024
2 checks passed
@fmaclen
Copy link
Owner

fmaclen commented Oct 22, 2024

🎉 This PR is included in version 0.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants