-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): Add Simplified Chinese translations #221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this PR!
I think it's good to go 👍
But before we merge, can you remove the commented lines in src/i18n/zh-cn/index.ts
?
src/i18n/zh-cn/index.ts
Outdated
// lowVram: '低 VRAM', 个人倾向于技术名词不做翻译,下方注释同理 | ||
// mainGpu: '主要 GPU', | ||
messageOfTheDay: '资讯', | ||
messages: '消息', | ||
// minP: 'Min P', | ||
// mirostat: 'Mirostat', | ||
// mirostatEta: 'Mirostat ETA', | ||
// mirostatTau: 'Mirostat Tau', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the comments in this file.
Done ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks again! 🚀
🎉 This PR is included in version 0.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This pull request adds Simplified Chinese Translations. resolve the i18n request of #212