Skip to content

Commit f862f6d

Browse files
authored
Rollup merge of rust-lang#124389 - CensoredUsername:master, r=petrochenkov
Add a warning to proc_macro::Delimiter::None that rustc currently does not respect it. It does not provide the behaviour it is indicated to provide when used in a proc_macro context. This seems to be a bug, (rust-lang#67062), but it is a long standing one, and hard to discover. This pull request adds a warning to inform users of this issue, with a link to the relevant issue, and a version number of the last known affected rustc version.
2 parents c99b3f2 + c2d2df1 commit f862f6d

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

library/proc_macro/src/lib.rs

+12
Original file line numberDiff line numberDiff line change
@@ -815,6 +815,18 @@ pub enum Delimiter {
815815
/// "macro variable" `$var`. It is important to preserve operator priorities in cases like
816816
/// `$var * 3` where `$var` is `1 + 2`.
817817
/// Invisible delimiters might not survive roundtrip of a token stream through a string.
818+
///
819+
/// <div class="warning">
820+
///
821+
/// Note: rustc currently can ignore the grouping of tokens delimited by `None` in the output
822+
/// of a proc_macro. Only `None`-delimited groups created by a macro_rules macro in the input
823+
/// of a proc_macro macro are preserved, and only in very specific circumstances.
824+
/// Any `None`-delimited groups (re)created by a proc_macro will therefore not preserve
825+
/// operator priorities as indicated above. The other `Delimiter` variants should be used
826+
/// instead in this context. This is a rustc bug. For details, see
827+
/// [rust-lang/rust#67062](https://github.com/rust-lang/rust/issues/67062).
828+
///
829+
/// </div>
818830
#[stable(feature = "proc_macro_lib2", since = "1.29.0")]
819831
None,
820832
}

0 commit comments

Comments
 (0)