Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fmt/chrono.h Unused Template Warning #1524

Closed
jwillikers opened this issue Jan 17, 2020 · 3 comments
Closed

fmt/chrono.h Unused Template Warning #1524

jwillikers opened this issue Jan 17, 2020 · 3 comments

Comments

@jwillikers
Copy link
Contributor

jwillikers commented Jan 17, 2020 •
edited
Loading

The fmt/chrono.h header produces an unused-template warning on clang for the function format_chrono_duration_unit. This is probably due to the templated function being static, from what I can tell.
@vitaut
Copy link
Contributor

vitaut commented Jan 17, 2020

Thanks for reporting. It shouldn't really be static - could you submit a PR?

@vitaut
Copy link
Contributor

vitaut commented Jan 18, 2020

Should be fixed in 9bd9738.

@vitaut vitaut closed this as completed Jan 18, 2020
@jwillikers
Copy link
Contributor Author

@vitaut Thanks! I can totally submit a PR next time. 👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitaut @jwillikers