Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::iterator_traits specialisation for fmt::appender breaks std::output_iterator concept #4092

Closed
teemu-torma opened this issue Jul 29, 2024 · 2 comments
Closed

std::iterator_traits specialisation for fmt::appender breaks std::output_iterator concept #4092

teemu-torma opened this issue Jul 29, 2024 · 2 comments

Comments

@teemu-torma
Copy link

fmt::basic_appender<char> does not match libstdc++ std::output_iterator concept, because std::iterator_traits<fmt::appender> does not match incrementable iterator concept.

Either removing the std::iterator_traits specialisation, or adding difference_type to it fixes the problem.

The specialisation was added in version 11.0.2
@vitaut
Copy link
Contributor

vitaut commented Jul 29, 2024

We should add difference_type. A PR would be welcome.

@phprus phprus mentioned this issue Jul 29, 2024
Merged
@phprus
Copy link
Contributor

phprus commented Jul 29, 2024

PR #4093

@vitaut vitaut closed this as completed Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@phprus @vitaut @teemu-torma