Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of deprecated React.findDOMNode #47

Closed
chekrd opened this issue May 29, 2019 · 2 comments
Closed

Get rid of deprecated React.findDOMNode #47

chekrd opened this issue May 29, 2019 · 2 comments

Comments

@chekrd
Copy link

chekrd commented May 29, 2019

React.StrictMode throws an error as focus-trap-react uses deprecated React API. See https://reactjs.org/docs/strict-mode.html#warning-about-deprecated-finddomnode-usage

Could you please update the package to work with RefObject?

@davidtheclark
Copy link
Collaborator

For now I'd rather continue supporting React 15 than support strict mode. Is it possible to do both?

@stefcameron
Copy link
Member

Closing in favor of #77.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants